-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
breaking(integration_test_charm.yaml): Enable RBAC for microk8s tests #256
Conversation
Set as breaking change as it may cause issues with test that don't set trust. Tested on https://github.com/canonical/pgbouncer-k8s-operator/actions/runs/12392459034/job/34593413343?pr=474 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I also increase the microk8s-setup
's timeout?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the purpose of this change to test --trust
?
rbac Enable Role Based Access Control for authorisation. Note that this is incompatible with some other add-ons.
from https://microk8s.io/docs/addons
will this cause incompatibilities with other addons that we use? e.g. metallb
I think we'll be refactoring how we work with microk8s addons during the move to charmcraft test/spread/concierge and would prefer to avoid changing defaults before then, unless there's a significant benefit
Kind of. There are already tests for it in PG/PGB (enabling RBAC during the Pytest run, tests get stuck during model cleanup), but they fail on libjuju 3.6.0.0. Beyond that, RBAC would be expected in production environments.
I don't think so, at least I had no issues locally with RBAC and metallb. RBAC is also enabled by default by the |
Merged main and retested on: https://github.com/canonical/pgbouncer-k8s-operator/actions/runs/12784818705/job/35640518144?pr=474 |
^ is there an urgent need? |
It's been a month, so clearly not. Closing for now, to be revisited at a more opportune time. |
Enable RBAC during microk8s setup in line with the default behaviour of charmed-kubernetes/actions-operator